Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate supported java version from 1.6 to 1.8 #281

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Migrate supported java version from 1.6 to 1.8 #281

merged 1 commit into from
Oct 18, 2023

Conversation

Hamlin-Li
Copy link

Hi,

Can I have a discussion about the supported jdk versions of zstd-jni?
In the build.sbt, jdk1.6 is still supported:

javacOptions ++= Seq("--release", "6", "-Xlint:unchecked")
...
doc / javacOptions := Seq("--release", "6")
...
OsgiKeys.requireCapability := "osgi.ee;filter:=\"(&(osgi.ee=JavaSE)(version>=1.6))\""

I'm not sure if this is necessary, but seems this blocks the usage of zstd-jni in jdk 17/21 and later?

$ javac -version
javac 17.0.2
hamlin@hamlin:~/workspace/tools$ javac --release 6 Test.java
error: release version 6 not supported
Usage: javac <options> <source files>
use --help for a list of possible options

Do we have a plan to migrate the supportted jdk version from 1.6 to 1.8? If positive, this is the pr to do it.

Thanks!

@Hamlin-Li Hamlin-Li mentioned this pull request Oct 17, 2023
Merged
@luben
Copy link
Owner

luben commented Oct 17, 2023

Yes, I think we should update the minimum supported version.

@luben luben merged commit b72307c into luben:master Oct 18, 2023
6 checks passed
@Hamlin-Li
Copy link
Author

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hamlin-Li @luben